mAi
f820fa5830
Per m's Q1 pick (b) (2026-05-29): legacy `/`, `/dashboard`, `/calendar`,
`/timeline`, `/graph` become `/views/{system-slug}`. Old routes
301-redirect to the new ones with chip params preserved; the legacy
?view=<uuid> param from 5i is resolved through the uuid → slug map
when present so old bookmarks land on the right user view.
System views (web/system_views.go):
- SystemView struct (Slug / Name / Icon / URL) — code-resident, never
rows in projax.views.
- AllSystemViews() returns the canonical five: tree, dashboard,
calendar, timeline, graph. Display order matches the existing
sidebar.
- LookupSystemView(slug) returns the matching entry or nil; the
reserved-slug list in store.IsReservedViewSlug (slice A) is kept
in sync.
- legacyRedirect(systemSlug) handler 301s with chip-param preservation
+ uuid → slug resolution for any leftover ?view=<uuid>.
Routes (web/server.go):
- GET /views/tree → handleTree (was GET /)
- GET /views/dashboard → handleDashboard
- GET /views/timeline → handleTimeline
- GET /views/calendar → handleCalendar
- GET /views/graph → handleGraph
- GET / → 301 → /views/tree
- GET /dashboard → 301 → /views/dashboard
- GET /timeline → 301 → /views/timeline
- GET /calendar → 301 → /views/calendar
- GET /graph → 301 → /views/graph
- POST action endpoints (/dashboard/task/*, /dashboard/pin, /admin/*)
stay where they are — those are RPC-ish, not page renders.
handleTree: dropped the `r.URL.Path != "/"` guard — the only entry
point now is /views/tree, mounted via the new route. Slice F removes
any residual references; this slice keeps the handler reachable.
computeChipCounts grew a `base string` arg so chip URLs anchor on the
caller's route (/views/tree for the system tree, /views/{slug} for
saved views). PageViewTypes recognises both legacy and /views/ keys
during the transition.
Template hrefs / hx-gets bulk-updated to the new URLs:
- layout.tmpl: every sidebar + bottom-nav entry points at
/views/{system-slug}. Active-state checks updated alongside.
- tree_section.tmpl, tree_card.tmpl, tree_kanban.tmpl: clear-filter
/ clear-all hrefs → /views/tree.
- calendar*.tmpl, timeline_section.tmpl, graph.tmpl,
dashboard_section.tmpl: every internal nav + filter link points at
the /views/{slug} surface.
- detail.tmpl, error.tmpl: cancel / back-to-tree → /views/tree.
Test-source updates (per the 5c sharpened rule):
- ~100 test paths bulk-rewritten from /dashboard /calendar /timeline
/graph (and `/`) to their /views/{slug} counterparts. The
behaviour-preservation contract holds: status codes + body shapes
for the rendered pages stay the same; only the URL anchoring the
test changes.
- layout_test.go: sidebar href assertions updated to /views/{slug}.
- view_type_test.go (Q2 + Q3 follow-up): PageViewTypes lookup table
updated to use the new route keys.
- 2 deliberate behaviour-change assertions land: TestLegacyRedirects
expects 301 on the old URLs (was 200); TestTreeRenders fetches
/views/tree (the new home) instead of /.
Internal go-source URL emissions (dashboard.go, calendar.go,
timeline.go) updated to the new BasePath so chip + refresh URLs round
through /views/{slug} correctly.
New tests:
- TestSystemViewLookup — AllSystemViews shape + LookupSystemView
round-trip + unknown-slug nil.
- TestLegacyRedirects — every legacy URL 301s to its new home with
chip params preserved.
- TestLegacyViewUUIDRedirect — old `?view=<uuid>` URLs land on the
resolved slug per m's Q3 pick.
72 lines
2.2 KiB
Go
72 lines
2.2 KiB
Go
package web_test
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// TestAdminIndexRenders proves /admin returns 200 with the three card links
|
|
// visible. Counts come from the live DB (orphan + total item counts run
|
|
// against projax.items_unified, so they reflect whatever m has seeded).
|
|
func TestAdminIndexRenders(t *testing.T) {
|
|
srv, pool := mustServer(t)
|
|
defer pool.Close()
|
|
h := srv.Routes()
|
|
code, body := get(t, h, "/admin")
|
|
if code != 200 {
|
|
t.Fatalf("GET /admin → %d body=%s", code, body)
|
|
}
|
|
for _, want := range []string{
|
|
`Classify orphans`,
|
|
`href="/admin/classify"`,
|
|
`Bulk edit`,
|
|
`href="/admin/bulk"`,
|
|
// CalDAV card title renders regardless of config; the link is only
|
|
// emitted when DAV_URL is configured. mustServer leaves CalDAV nil,
|
|
// so we only assert the card text exists (with a "DAV_URL not
|
|
// configured" stub instead of a link).
|
|
`CalDAV calendars`,
|
|
`admin-cards`,
|
|
`admin-system`,
|
|
// system panel scaffold
|
|
`Last migration`,
|
|
`MCP`,
|
|
} {
|
|
if !strings.Contains(body, want) {
|
|
t.Errorf("/admin missing %q", want)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestLayoutHasAdminNavLink proves the header nav across every chrome-bearing
|
|
// route exposes /admin. Without the link the index page is invisible — m
|
|
// reported that as the headline bug.
|
|
func TestLayoutHasAdminNavLink(t *testing.T) {
|
|
srv, pool := mustServer(t)
|
|
defer pool.Close()
|
|
h := srv.Routes()
|
|
for _, path := range []string{"/views/tree", "/views/dashboard", "/views/graph", "/admin/bulk", "/admin/classify"} {
|
|
_, body := get(t, h, path)
|
|
if !strings.Contains(body, `href="/admin"`) {
|
|
t.Errorf("GET %s: nav missing /admin link", path)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestAdminCountsReflectStore: seed an item, render /admin, item count
|
|
// goes up by 1. Stale-cache regression guard.
|
|
func TestAdminCountsReflectStore(t *testing.T) {
|
|
srv, pool := mustServer(t)
|
|
defer pool.Close()
|
|
h := srv.Routes()
|
|
|
|
// Baseline.
|
|
_, before := get(t, h, "/admin")
|
|
// Count occurrences of "items in scope" — the bulk card's label. The card
|
|
// renders Count + CountLabel; assert the label is present and that we can
|
|
// parse the number on either side of the strong tag.
|
|
if !strings.Contains(before, "items in scope") {
|
|
t.Fatalf("baseline /admin missing 'items in scope' label")
|
|
}
|
|
}
|