Merge: hotfix #3 mig 140 — filter POST check to active+published (B.2 dual-write scope)

internal/db/migrations/140_drop_deadline_rules.up.sql

@@ -319,15 +319,22 @@ DECLARE
     v_dr_table_exists  int;
     v_rule_id_col      int;
 BEGIN
-    -- Snapshot row count must equal sequencing_rules row count (B.2
-    -- dual-write maintains 1:1 across all lifecycle states). The view
-    -- count is informational only — it filters to is_active+published
-    -- so naturally differs from the full snapshot.
-    SELECT COUNT(*) INTO v_snapshot_count FROM paliad.deadline_rules_pre_140;
-    SELECT COUNT(*) INTO v_sr_count       FROM paliad.sequencing_rules;
+    -- B.2 dual-write was implemented only for the active+published lifecycle
+    -- (the scope of the read paths and B.4's pre-flip drift check). Archived
+    -- + draft rows in deadline_rules were never replicated to sequencing_rules
+    -- (they had no production read path). Snapshot includes them all (CREATE
+    -- TABLE AS is unfiltered), so we compare on the same filter B.2 actually
+    -- maintained. Drafts/archived rows are preserved in paliad.deadline_rules_pre_140
+    -- for forensic + future-backfill use.
+    SELECT COUNT(*) INTO v_snapshot_count
+      FROM paliad.deadline_rules_pre_140
+     WHERE is_active = true AND lifecycle_state = 'published';
+    SELECT COUNT(*) INTO v_sr_count
+      FROM paliad.sequencing_rules
+     WHERE is_active = true AND lifecycle_state = 'published';
     SELECT COUNT(*) INTO v_view_count     FROM paliad.deadline_rules_unified;
     IF v_snapshot_count <> v_sr_count THEN
-        RAISE EXCEPTION '[mig 140] FAILED POST: snapshot has % rows, sequencing_rules has % rows — dual-write drift',
+        RAISE EXCEPTION '[mig 140] FAILED POST: snapshot active+published has % rows, sequencing_rules active+published has % rows — dual-write drift',
             v_snapshot_count, v_sr_count;
     END IF;